Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack-dev-server #2806

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Upgrade webpack-dev-server #2806

merged 1 commit into from
Jul 18, 2017

Conversation

christianbundy
Copy link
Contributor

@christianbundy christianbundy commented Jul 17, 2017 •
edited
Loading

This resolves another iteration of #1268 which was resolved in webpack/webpack-dev-server#975. The current error is:

Uncaught Error: Incompatible SockJS! Main site uses: "1.1.4", the iframe: "1.1.2".

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 1.0.11 milestone Jul 18, 2017
@Timer
Copy link
Contributor

Timer commented Jul 18, 2017

Great, thanks for catching this!
I wish we could be more careful about this but I'm not sure about comments in package.json.

@Timer Timer merged commit 0482058 into facebook:master Jul 18, 2017
@Timer
Copy link
Contributor

Timer commented Aug 9, 2017

Hi there! This change is out in react-scripts@1.0.11; please give it a go! Thanks.

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017
@christianbundy @JohnNilsson
Upgrade webpack-dev-server (#2806)
14644b6
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@christianbundy @morgs32
Upgrade webpack-dev-server (facebook#2806)
6d50d4e
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017
@christianbundy @JohnNilsson
Upgrade webpack-dev-server (#2806)
834515f
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@christianbundy @kasperpeulen
Upgrade webpack-dev-server (facebook#2806)
86a97db
swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017
@christianbundy @swengorschewski
Upgrade webpack-dev-server (#2806)
7432471
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
1.0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@christianbundy @facebook-github-bot @Timer